Add the "invert condition" property to AnimationNodeStateMachineTransition #36434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riteo
force-pushed
the
animationnodestatemachinetransition-invert-condition
branch
from
d6d4ac4 to
c2038f0
Compare
Riteo
requested review from
akien-mga,
AndreaCatania,
BastiaanOlij,
bojidar-bg,
JFonS,
neikeq,
reduz,
vnen and
a team
as code owners
Calinou
removed request for
BastiaanOlij,
JFonS,
akien-mga,
bojidar-bg,
vnen,
reduz,
neikeq and
AndreaCatania
Calinou
reviewed
Feb 25, 2020
…tion. When true, it will advance when its condition evaluates to false. Co-Authored-By: Hugo Locurcio <hugo.locurcio@hugo.pro>
Riteo
force-pushed
the
animationnodestatemachinetransition-invert-condition
branch
from
188b269 to
904db4d
Compare
|
@Riteo maybe your can solve the conflicts? would love to see this in 4.0 🧡 |
|
@floriandotorg actually I think that #54327 might be a better solution to this problem. If it doesn't pass through I'll gadly rebase this though. |
|
Superseded by #54327. |
Riteo
deleted the
animationnodestatemachinetransition-invert-condition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves godotengine/godot-proposals#454
Adds the "Invert Condition" parameter to AnimationNodeStateMachinetransition, which avoids the creation of "not" conditions("IsMoving" "NotIsMoving")
Also, i've created a quick test project for testing this feature at https://github.com/Riteo/godot-invert-condition-test-project